Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing colon on schema.yml and add unit test on it #866

Merged
merged 5 commits into from
May 27, 2022
Merged

Fix missing colon on schema.yml and add unit test on it #866

merged 5 commits into from
May 27, 2022

Conversation

is3ka1
Copy link
Contributor

@is3ka1 is3ka1 commented May 27, 2022 •
edited
Loading

Description

I think there are some missing colons.

I found this when I using code generator tool, not sure if there is a unit test on schema.yml.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@nsano-rururu
Copy link
Collaborator

Please add ChangeLog.
https://github.com/jertel/elastalert2/blob/master/CHANGELOG.md#other-changes

@nsano-rururu
Copy link
Collaborator

Certainly there is no unit test for schema.yml

@nsano-rururu
Copy link
Collaborator

No Checklist has been checked. Didn't you see the guidelines?

jertel
jertel previously approved these changes May 27, 2022
View reviewed changes
@is3ka1 is3ka1 changed the title Fix missing colon on schema.yml Fix missing colon on schema.yml and add unit test on it May 27, 2022
@is3ka1
Copy link
Contributor Author

is3ka1 commented May 27, 2022

I add a unit test to load_rule_schema, hope this is helpful.

@jertel jertel merged commit 888b50b into jertel:master May 27, 2022
@is3ka1 is3ka1 deleted the patch-1 branch May 28, 2022 08:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jertel jertel jertel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@is3ka1 @nsano-rururu @jertel